Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Design changes to main panels #165687

Closed
wants to merge 10 commits into from
Closed

[Discover] Design changes to main panels #165687

wants to merge 10 commits into from

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Sep 5, 2023

Summary

This PR updates Discover styles:

  • removes background from panels, tabs and sidebar
  • updates "Add a field" button style
  • removes shadow from field list items
  • makes field search compact
Screenshot 2023-09-05 at 14 54 35

@jughosta jughosta added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Sep 5, 2023
@jughosta jughosta self-assigned this Sep 5, 2023
@jughosta jughosta marked this pull request as ready for review September 5, 2023 15:56
@jughosta jughosta requested review from a team as code owners September 5, 2023 15:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@andreadelrio andreadelrio mentioned this pull request Sep 6, 2023
Closed
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 6, 2023 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Security Investigations Cypress Tests #5 / Export timelines "before all" hook for "Exports custom timeline(s)" "before all" hook for "Exports custom timeline(s)"
  • [job] [logs] Serverless Security Cypress Tests #1 / Sourcerer Default scope "before each" hook for "correctly loads SIEM data view" "before each" hook for "correctly loads SIEM data view"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
discover 631 645 +14
eventAnnotation 428 442 +14
lens 1139 1153 +14
logExplorer 319 333 +14
total +56

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 550.3KB 550.9KB +615.0B
lens 1.4MB 1.4MB +14.0B
total +629.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

@jughosta
Copy link
Contributor Author

jughosta commented Sep 6, 2023

Closing in favour of a single PR with all redesign changes #165866

@jughosta jughosta closed this Sep 6, 2023
@jughosta jughosta mentioned this pull request Sep 6, 2023
Merged
jughosta added a commit that referenced this pull request Sep 12, 2023
@jughosta @kibanamachine @davismcphee
[Discover] Redesign for the grid, panels and sidebar v1 (#165866)
6cb937a 
## Summary

### Part 1

- Resolves #164287
- Closes #146339
- Previously separate PR #164187

Changes:
- ~~swaps checkbox and row selection~~
- removes vertical borders
- adds rows highlight
- increases cell padding
- adds row stripes
- updates header background
- removes grey background from field name and makes it bolder (part of
#164634)
- updates Surrounding Documents side paddings

### Part 2

- Resolves #164661
- Previously separate PR #165687

Changes:
- removes background from panels, tabs and sidebar
- updates "Add a field" button style
- removes shadow from field list items
- makes field search compact

### Part 3

- Resolves #164662

Changes:
- wraps "Add a field" button in its own container with a top border
- ~~adds a drag handle to sidebar items~~
- ~~adds new Show/Hide buttons to toggle sidebar~~ moves sidebar toggle
button from discover plugin to unified field list
- reduces spaces between sidebar items from 4px to 2px
- reduces padding on Single Document page
- removes border above grid tabs

<img width="600" alt="Screenshot 2023-09-07 at 14 39 48"
src="https://github.com/elastic/kibana/assets/1415710/976db247-fd70-4c9b-8634-552ece45b522">


Please note that "auto" row height is in a separate PR which is also
ready for review #164218

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Davis McPhee <davismcphee@hotmail.com>
Co-authored-by: Davis McPhee <davis.mcphee@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jughosta jughosta

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Discover] Design changes to main panels
4 participants
@jughosta @elasticmachine @kibana-ci @kibanamachine